Contributions are welcome, and they are greatly appreciated! Every little bit helps, and credit will always be given.
When reporting a bug please include:
- Your operating system name and version.
- Any details about your local setup that might be helpful in troubleshooting.
- Detailed steps to reproduce the bug.
MyAnimeList Scraper could always use more documentation, whether as part of the official MyAnimeList Scraper docs, in docstrings, or even on the web in blog posts, articles, and such.
Feature requests and feedback¶
The best way to send feedback is to file an issue at https://github.com/QasimK/mal-scraper/issues.
If you are proposing a feature:
- Explain in detail how it would work.
- Keep the scope as narrow as possible, to make it easier to implement.
- Remember that this is a volunteer-driven project, and that code contributions are welcome :)
We follow (and our tests check):
To set up mal-scraper for local development:
Fork mal-scraper (look for the “Fork” button).
Clone your fork locally:
git clone firstname.lastname@example.org:your_name_here/mal-scraper.git
Ensure Pipenv is installed on your computer and install the development packages:
pipenv install --dev
Create a branch for local development:
git checkout -b name-of-your-bugfix-or-feature
Now you can make your changes locally.
When you’re done making changes, run all the checks, doc builder and spell checker with tox one command:
pipenv run tox
The newly built HTML docs can be found within the dist folder in the repo.
Commit your changes and push your branch to GitHub:
git add . git commit -m "Your detailed description of your changes." git push origin name-of-your-bugfix-or-feature
Submit a pull request through the GitHub website.
Pull Request Guidelines¶
If you need some code review or feedback while you’re developing the code just make the pull request.
For merging, you should:
- Include passing tests (run
- Update documentation when there’s new API, functionality etc.
- Add a note to
CHANGELOG.rstabout the changes.
- Add yourself to
If you don’t have all the necessary python versions available locally you can rely on Travis - it will run the tests for each change you add in the pull request.
It will be slower though …
To run the test-suite quickly:
To run a subset of tests:
tox -e envname -- py.test -k test_myfeature
To skip Python environments that you do not have installed:
To run all the test environments in parallel (you need to
pip install detox):
- Bump Version
- Upload to Pypi
python setup.py sdist bdist_wheel upload -r pypi